[PATCH] D30364: AArch64 : Add PreferCSEL feature.

Junmo Park via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 2 20:25:37 PST 2017


flyingforyou added a comment.

Thanks for your opinion & example Renato.

When I asked about this issue to James, actually he suggested to use term "SlowCSINV". 
In ARMInstrInfo.td, there is definition use "DontUse" or "Use" even if they support instructions as I mentioned before.

  def UseVMOVSR : Predicate<"Subtarget->preferVMOVSR() ||"
                            "!Subtarget->useNEONForSinglePrecisionFP()">;
  def DontUseVMOVSR : Predicate<"!Subtarget->preferVMOVSR() &&"
                                "Subtarget->useNEONForSinglePrecisionFP()">;

So, are they also changed to "HasFastVMOVSR" and "HasSlowVMOVSR" ?

And

  def DontUseCSEL : Predicate<"!Subtarget->preferCSEL()">;

And Is this ok that change the definition from `DontUseCSEL` to `HasFastCSEL`?


https://reviews.llvm.org/D30364





More information about the llvm-commits mailing list