[PATCH] D30555: LTO: Hash type identifier resolutions for WholeProgramDevirt.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/lib/LTO/LTO.cpp:104
+    Hasher.update(ArrayRef<uint8_t>{Data, 8});
+  };
   AddString(Conf.CPU);
----------------
mehdi_amini wrote:
> Why do we hash bit-by-bit? Is it because of endianness? Do we care about having the same hash on different endian machine?
It makes the code easier to reason about if you always use the same hash function rather than making the code machine dependent.


https://reviews.llvm.org/D30555