[PATCH] D30505: Allow users to force clean builds from the web

[Galina via Phabricator via llvm-commits]

gkistanova added a comment.

Hello Reid,

Thanks for refactoring the ClangBuilder.

Unless I'm missing something, there are 3 changes in this patch:

1. Clean property usage (in the title of this review item),
2. Refactoring condition when a stage 1 build should install the results,
3. Cleaning installed files and refactoring a bit the build files clean step  on stage 2.

What do you think about splitting this to 3 patches?



================
Comment at: zorg/buildbot/builders/ClangBuilder.py:633
+                           command=['rm','-rf',stage1_build],
+                           warnOnFailure=True,
+                           description='cleaning stage 1',
----------------
Maybe using RemoveDirectory is more compatible? This command wouldn't work well on Windows targets.


================
Comment at: zorg/buildbot/builders/ClangBuilder.py:654
+        # exists to see if we can avoid an extra cmake run.
         f.addStep(SetProperty(name="check ninja files 1",
                               workdir=stage1_build,
----------------
You can skip this step and use `FileDoesNotExist` from `zorg.buildbot.conditions.FileConditions` in `doStepIf` of that cmake command instead.



https://reviews.llvm.org/D30505