[PATCH] D30524: Extract FindAvailablePtrLoadStore out of FindAvailableLoadedValue. NFCI
Jun Bum Lim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 2 12:51:19 PST 2017
junbuml added inline comments.
================
Comment at: lib/Analysis/Loads.cpp:326
+
+Value *llvm::FindAvailablePtrLoadStore(Value *Ptr, Type *AccessTy,
+ bool AtLeastAtomic, BasicBlock *ScanBB,
----------------
trentxintong wrote:
> junbuml wrote:
> > Don't you need to have if (!Load->isUnordered()) in FindAvailablePtrLoadStore as well?
> We cant check for that as we are passing in a Ptr, the check needs to be done outside.
What about passing both load and pointer accessed to FindAvailableLoadedValue ?
https://reviews.llvm.org/D30524
More information about the llvm-commits
mailing list