[PATCH] D30546: Fully precise gc handling of __start and __stop symbols

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 2 12:17:28 PST 2017


ruiu added inline comments.


================
Comment at: ELF/MarkLive.cpp:68
+// identifiers, so we just store a std::vector instead of a multimap.
+static std::vector<InputSectionBase *> CNamedSections;
+
----------------
Can you .reset() this at beginning of markLive() so that markLive is safe to run more than once.

Maybe DenseSet instead of a vector? It is a set of strings, so a set seems more natural.


https://reviews.llvm.org/D30546





More information about the llvm-commits mailing list