[PATCH] D29344: [AArch64] Extend redundant copy elimination pass to handle non-zero stores.

[Geoff Berry via Phabricator via llvm-commits]

gberry accepted this revision.
gberry added a comment.

LGTM with a few nits



================
Comment at: lib/Target/AArch64/AArch64RedundantCopyElimination.cpp:212
+  // updating FirstUse when scanning for COPY instructions.  In particular, if
+  // there's a COPY inbetween the compare and branch the COPY should not
+  // update FirstUse.
----------------
Typo 'inbetween' -> 'in between'


================
Comment at: test/CodeGen/AArch64/machine-copy-remove.mir:408
+...
+# We can't eliminated the MOVi32imm because of the clobbering LDRWui.
+# CHECK-LABEL: name: test14
----------------
Typo 'eliminated' -> 'eliminate'.  And another before test15.


https://reviews.llvm.org/D29344