[PATCH] D30500: [ELF] - Do not treat colon(":") as separate token in script parser.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 2 09:18:10 PST 2017
ruiu added inline comments.
================
Comment at: ELF/LinkerScript.cpp:1943-1944
// no label, we assume global symbols.
- if (peek() != "local") {
- if (consume("global"))
- expect(":");
+ if (!peekLabel("local:")) {
+ consumeLabel("global:");
for (SymbolVersion V : readSymbols())
----------------
I think you can do that without defining `peekLabel`. You should remove the first two lines from readLocals().
https://reviews.llvm.org/D30500
More information about the llvm-commits
mailing list