[PATCH] D30491: [AArch64AsmParser] cleanup/rewrite of function parseSysAlias

[Renato Golin via Phabricator via llvm-commits]

rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

Much better! The error messages are already being tested, and you haven't changed a bit, so they should be fine.

LGTM, thanks!



================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:2337
 
+static void setRequiredFeatureString(FeatureBitset FBS, std::string &Str) {
+  if (FBS[AArch64::HasV8_1aOps])
----------------
If the target parser was already connected to table-gen, this wouldn't be necessary. :(


================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:2421
     }
+    createSysAlias(TLBI->Encoding, Operands, S);
   }
----------------
Its a shame these are completely different namespaces. The code could have been so much simpler. :)


https://reviews.llvm.org/D30491