[PATCH] D30525: [APInt] Add setLowBits/setHighBits methods to APInt.
Davide Italiano via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 1 23:50:08 PST 2017
davide added inline comments.
================
Comment at: include/llvm/ADT/APInt.h:1253
+ assert(loBits <= BitWidth && "Too many bits to set!");
+ // Handle a degenerate case, to avoid shifting by word size
+ if (loBits == 0)
----------------
Please end comments with a full stop (here and everywhere else). I know we're a bit inconsistent in this file, but we should get this right for newly introduced code.
https://reviews.llvm.org/D30525
More information about the llvm-commits
mailing list