[PATCH] D30471: [DAG] Relax conditions under stores of loaded values can be merged

[Nirav Dave via Phabricator via llvm-commits]

niravd marked an inline comment as done.
niravd added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:12015
+                  (isa<ConstantFPSDNode>(OtherST->getValue()) ||
+                   isa<LoadSDNode>(OtherST->getValue()))))
               continue;
----------------
efriedma wrote:
> Is this a correctness check, or a profitability check?  At first glance, it isn't obvious why we're checking any of this here.
Folded in some pending code cleanup that makes this a bit mroe clear. This is a filter to make sure we only get mergeable candidates that would be profitable.



https://reviews.llvm.org/D30471