[PATCH] D30513: [NVPTX] Reduce amount of boilerplate code used to select load instruction opcode.

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 1 16:33:35 PST 2017


tra marked an inline comment as done.
tra added a comment.

In https://reviews.llvm.org/D30513#690102, @jlebar wrote:

> > This patch also catches number of f16 load variants that were not handled before.
>
> Do we want to add tests so we don't regress this?


Some of these instructions need additional help during lowering, so there's no easy way to emit them now.
I'll send another patch which will fix f16 load/store lowering and will include better tests.


https://reviews.llvm.org/D30513





More information about the llvm-commits mailing list