[PATCH] D30380: Teach lit to expand glob expressions

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 1 16:06:04 PST 2017


rnk added a comment.

We had some offline discussion about this. I would really like the lit shell to be as much like bash as possible to match test writers' expectations. As Mehdi mentioned, there are cases where an LLVM tool does not generate output in a predictable location, like clang crash recovery. I'd like to test this with regular shell globbing if possible. It sounds like Zach's going to give that a try.

I think we need to look for unescaped '*' and '?' in the lit shell lexer (ShUtil.py), replace that with an unambiguous escape sequence (%{globstart} and %{globquestion} or something), and then evaluate those immediately before Popen.


https://reviews.llvm.org/D30380





More information about the llvm-commits mailing list