[llvm] r296709 - Improve mulhi overflow test. NFC
Amaury Sechet via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 1 15:31:20 PST 2017
Author: deadalnix
Date: Wed Mar 1 17:31:19 2017
New Revision: 296709
URL: http://llvm.org/viewvc/llvm-project?rev=296709&view=rev
Log:
Improve mulhi overflow test. NFC
Modified:
llvm/trunk/test/CodeGen/X86/overflow.ll
Modified: llvm/trunk/test/CodeGen/X86/overflow.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/overflow.ll?rev=296709&r1=296708&r2=296709&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/overflow.ll (original)
+++ llvm/trunk/test/CodeGen/X86/overflow.ll Wed Mar 1 17:31:19 2017
@@ -2,36 +2,47 @@
; RUN: llc < %s -mtriple=i686-unknown-unknown -mattr=+avx | FileCheck %s --check-prefix=X32
; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx | FileCheck %s --check-prefix=X64
-define i1 @mulhioverflow(i64 %a, i64 %b, i64 %c) nounwind {
+define i128 @mulhioverflow(i64 %a, i64 %b, i64 %c) nounwind {
; X32-LABEL: mulhioverflow:
; X32: # BB#0:
; X32-NEXT: pushl %ebp
; X32-NEXT: movl %esp, %ebp
+; X32-NEXT: pushl %edi
; X32-NEXT: pushl %esi
; X32-NEXT: andl $-8, %esp
-; X32-NEXT: subl $24, %esp
-; X32-NEXT: movl 24(%ebp), %esi
+; X32-NEXT: subl $16, %esp
+; X32-NEXT: movl 8(%ebp), %esi
+; X32-NEXT: movl 28(%ebp), %edi
; X32-NEXT: movl %esp, %eax
; X32-NEXT: pushl $0
; X32-NEXT: pushl $0
+; X32-NEXT: pushl 24(%ebp)
; X32-NEXT: pushl 20(%ebp)
-; X32-NEXT: pushl 16(%ebp)
; X32-NEXT: pushl $0
; X32-NEXT: pushl $0
+; X32-NEXT: pushl 16(%ebp)
; X32-NEXT: pushl 12(%ebp)
-; X32-NEXT: pushl 8(%ebp)
; X32-NEXT: pushl %eax
; X32-NEXT: calll __multi3
; X32-NEXT: addl $32, %esp
; X32-NEXT: movl {{[0-9]+}}(%esp), %eax
-; X32-NEXT: andl $1, %esi
-; X32-NEXT: addl {{[0-9]+}}(%esp), %esi
+; X32-NEXT: andl $1, %edi
+; X32-NEXT: xorl %ecx, %ecx
+; X32-NEXT: addl {{[0-9]+}}(%esp), %edi
; X32-NEXT: adcl $0, %eax
-; X32-NEXT: setb %al
-; X32-NEXT: leal -4(%ebp), %esp
+; X32-NEXT: adcl $0, %ecx
+; X32-NEXT: sbbl %edx, %edx
+; X32-NEXT: andl $1, %edx
+; X32-NEXT: movl %edi, (%esi)
+; X32-NEXT: movl %eax, 4(%esi)
+; X32-NEXT: movl %ecx, 8(%esi)
+; X32-NEXT: movl %edx, 12(%esi)
+; X32-NEXT: movl %esi, %eax
+; X32-NEXT: leal -8(%ebp), %esp
; X32-NEXT: popl %esi
+; X32-NEXT: popl %edi
; X32-NEXT: popl %ebp
-; X32-NEXT: retl
+; X32-NEXT: retl $4
;
; X64-LABEL: mulhioverflow:
; X64: # BB#0:
@@ -40,7 +51,9 @@ define i1 @mulhioverflow(i64 %a, i64 %b,
; X64-NEXT: mulq %rsi
; X64-NEXT: andl $1, %ecx
; X64-NEXT: addq %rdx, %rcx
-; X64-NEXT: setb %al
+; X64-NEXT: sbbq %rdx, %rdx
+; X64-NEXT: andl $1, %edx
+; X64-NEXT: movq %rcx, %rax
; X64-NEXT: retq
%1 = zext i64 %a to i128
%2 = zext i64 %b to i128
@@ -49,7 +62,5 @@ define i1 @mulhioverflow(i64 %a, i64 %b,
%5 = and i64 %c, 1
%6 = zext i64 %5 to i128
%7 = add i128 %4, %6
- %8 = lshr i128 %7, 64
- %9 = trunc i128 %8 to i1
- ret i1 %9
+ ret i128 %7
}
More information about the llvm-commits
mailing list