[lld] r296429 - Add Triple::thumb to getBitcodeMachineKind

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 1 15:02:32 PST 2017


On Wed, Mar 1, 2017 at 10:31 AM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Sean Silva <chisophugis at gmail.com> writes:
>
> > Do you think it's worth having a test case for this? It seems like it
> would
> > basically end up being one of those "I can copy the same string in two
> > places" types of things.
>
> Before this patch any lto using a .bc with thumb triple would fail, no?
>

Yes, but do we really want to have one such test for every case in this
switch? It seems awfully redundant.

-- Sean Silva


>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170301/ec448897/attachment.html>


More information about the llvm-commits mailing list