[PATCH] D30380: Teach lit to expand glob expressions

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 1 14:57:15 PST 2017


rnk added inline comments.


================
Comment at: llvm/utils/lit/lit/TestRunner.py:147
+    result = [args[0]]
+    expr = re.compile(r"%\[\[(.*?)]]")
+    for arg in args[1:]:
----------------
Why look for double square brackets at all? The lit shell is supposed to be bash compatible, since we use bash on Linux and the internal shell on Windows. Can we just look for '*'?


https://reviews.llvm.org/D30380





More information about the llvm-commits mailing list