[PATCH] D30352: [JumpThread] Use AA in SimplifyPartiallyRedundantLoad()

Jun Bum Lim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 1 14:28:01 PST 2017


junbuml updated this revision to Diff 90230.
junbuml added a comment.
Herald added a subscriber: aemerson.

Added another test reduced from spec2000/crafty. This test shows the case caught by this change in https://reviews.llvm.org/owners/package/3/. I didn't see why other passes before jump thread didn't handle this. Please let me know if you believe this need to be handled before jump thread in other pass.

As I mentioned before, the main purpose of SimplifyPartiallyRedundantLoad() is to encourage jump threading opportunities, and it is run  interlaced with other jump threading tasks. Based on that, improving SimplifyPartiallyRedundantLoad() would be profitable even though the other pass can do the same (or even better) job in other places. Hopefully, the test added shows the case caught by this change properly as well as expose opportunities for other passes.


https://reviews.llvm.org/D30352

Files:
  include/llvm/Transforms/Scalar/JumpThreading.h
  lib/Transforms/Scalar/JumpThreading.cpp
  test/Transforms/JumpThreading/thread-loads.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30352.90230.patch
Type: text/x-patch
Size: 10712 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170301/6d6260a0/attachment.bin>


More information about the llvm-commits mailing list