[PATCH] D30267: Increase stack size for stack-use-after-return test

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 1 14:12:38 PST 2017


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D30267#689647, @fjricci wrote:

> There's a more detailed explanation in https://reviews.llvm.org/D29994, but essentially, some debugging found that 64k isn't actually being used for the stack size consistently, and the test never passes when 64k is actually used. (actual stack size used determined with `pthread_attr_getstacksize`)


I noticed that all sanitizers other than ASan intercept pthread_create and call AdjustStackSize, but this test doesn't seem to relate to that. The stack limit was added in https://reviews.llvm.org/rL189457, which is from 2013. The comments don't suggest that there was any great reason to choose 64K. Go ahead and raise it, then.


https://reviews.llvm.org/D30267





More information about the llvm-commits mailing list