[PATCH] D30506: [DAG] Prevent Stale nodes from entering worklist

[James Y Knight via Phabricator via llvm-commits]

jyknight added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:137
+      // Don't add deleted nodes. This can happen when a change
+      // to a operand causes redundancies.
+      if (N->getOpcode() == ISD::DELETED_NODE)
----------------
hfinkel wrote:
> What does "causes redundancies" mean?
I'd suggest to put an assert here instead, and put an if (opcode==ISD::DELETED_NODE) in the caller that requires it.


https://reviews.llvm.org/D30506