[PATCH] D29185: [lit] Allow llvm's build and test systems to support paths with spaces

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 1 10:47:42 PST 2017


rnk added a comment.

@chandlerc are you happy with the lit test as is checked in with paths with spaces? It's out of the way for any consumer who isn't trying to test lit directly.

Other than that I think this is good.



================
Comment at: utils/lit/tests/sp aces/spaces-in-paths.py:3
+
+# RUN: %{lit} -j 1 -v check-for-spaces.py
----------------
We could avoid checking in paths with spaces by doing something like:
```
RUN: mkdir "path with space"
RUN: cp %S/Inputs/check-for-spaces.py "path with space"
RUN: cd "path with space"
RUN: %{lit} -j1 -v check-for-spaces.py
```


https://reviews.llvm.org/D29185





More information about the llvm-commits mailing list