[PATCH] D30484: [DWARF] Default lower bound should respect requested DWARF version

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 1 10:39:21 PST 2017


probinson added a comment.

In https://reviews.llvm.org/D30484#689717, @aprantl wrote:

> LGTM.
>  Could you also add the missing languages (at least BLISS & Renderscript) to the switch while you are in there?


Sure.  Dwarf.def didn't have BLISS, and also had Python grouped with v5, when it was actually introduced in v4, so I added a comment there.

And of course... v2 and v3 define a default lower bound only for C, C++, and Fortran (in the dialects defined in those versions).  Patched that up too.

Now I want to alphabetize each group of cases in getDefaultLowerBound...  I'll do that as a followup NFC.


https://reviews.llvm.org/D30484





More information about the llvm-commits mailing list