[PATCH] D29489: Optimize SETCC + VSEL of incompatible or illegal types

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 1 10:29:01 PST 2017


tra added inline comments.


================
Comment at: test/CodeGen/NVPTX/f16x2-instructions.ll:425-426
 ; CHECK-DAG:  ld.param.b32    [[D:%hh[0-9]+]], [test_select_cc_f32_f16_param_3];
-; CHECK-DAG:  mov.b32         {[[C0:%h[0-9]+]], [[C1:%h[0-9]+]]}, [[C]]
-; CHECK-DAG:  mov.b32         {[[D0:%h[0-9]+]], [[D1:%h[0-9]+]]}, [[D]]
 ;
----------------
jonpa wrote:
> tra wrote:
> > I think these are still needed (see cvt.f32... below)  and should become CHECK-NOF16-DAG now.
> Is this looking ok?
LGTM.


https://reviews.llvm.org/D29489





More information about the llvm-commits mailing list