[PATCH] D29344: [AArch64] Extend redundant copy elimination pass to handle non-zero stores.

Chad Rosier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 1 09:22:45 PST 2017


mcrosier updated this revision to Diff 90194.
mcrosier marked 5 inline comments as done.
mcrosier added a comment.

-Address Geoff's inline comments.
-Add a few negative tests.
-Use a single ClobberReg bit vector to track clobbered registers.

While I think it's possible to only scan the predecessor instructions once, I believe it would add a fair amount of complexity.  More importantly we would need to maintain a list of copies every time we scan the predecessors (even in those cases when we can't optimize the move immediate/copy, which is the common case).  Regardless, I'm happy to discuss this offline and update everyone with the result of that discussion.


https://reviews.llvm.org/D29344

Files:
  lib/Target/AArch64/AArch64RedundantCopyElimination.cpp
  test/CodeGen/AArch64/machine-copy-remove.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D29344.90194.patch
Type: text/x-patch
Size: 20164 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170301/4394bc69/attachment-0001.bin>


More information about the llvm-commits mailing list