[PATCH] D30486: [APInt] Optimize APInt creation from uint64_t

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 1 08:40:18 PST 2017


hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: include/llvm/ADT/APInt.h:246
+      clearUnusedBits();
+    } else
       initSlowCase(val, isSigned);
----------------
Maybe it's just me, but I always find `} else` to look weird. I'd suggest putting braces around the else-branch too.


https://reviews.llvm.org/D30486





More information about the llvm-commits mailing list