[PATCH] D30451: [X86][AVX512] Adding new LLVM TableGen backend which generates the EVEX2VEX compressing tables.

[Ayman Musa via Phabricator via llvm-commits]

aymanmus marked 2 inline comments as done.
aymanmus added inline comments.


================
Comment at: utils/TableGen/X86EVEX2VEXTablesEmitter.cpp:68
+  const vector<string> ExceptionList = {
+      "VCVTQQ2PD",
+      "VCVTQQ2PS",
----------------
craig.topper wrote:
> Why is this a vector and not just a static table of strings?
> 
> Can you add a comment indicating what each of these corresponds to in VEX just so if someone is curious they easily find it?
Any table defined inside the class would require stating the size when defined (ExceptionList[11]), So I figured it's more maintainable this way.
The mappings of these instructions to VEX instructions make no sense, there is no "meaning" to the relation.


https://reviews.llvm.org/D30451