[PATCH] D30497: [SelectionDAG] Make SelectCode return void

Sven van Haastregt via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 1 05:47:22 PST 2017


svenvh created this revision.

SelectCode has been returning nullptr since 182dac0 ("SDAG: Make
SelectCodeCommon return void", 2016-05-10).  Make SelectCode also
return void instead, as all callers have been updated.


https://reviews.llvm.org/D30497

Files:
  utils/TableGen/DAGISelMatcherEmitter.cpp


Index: utils/TableGen/DAGISelMatcherEmitter.cpp
===================================================================
--- utils/TableGen/DAGISelMatcherEmitter.cpp
+++ utils/TableGen/DAGISelMatcherEmitter.cpp
@@ -955,7 +955,7 @@
   formatted_raw_ostream OS(O);
 
   OS << "// The main instruction selector code.\n";
-  OS << "SDNode *SelectCode(SDNode *N) {\n";
+  OS << "void SelectCode(SDNode *N) {\n";
 
   MatcherTableEmitter MatcherEmitter(CGP);
 
@@ -970,7 +970,6 @@
 
   OS << "  #undef TARGET_VAL\n";
   OS << "  SelectCodeCommon(N, MatcherTable,sizeof(MatcherTable));\n";
-  OS << "  return nullptr;\n";
   OS << "}\n";
 
   // Next up, emit the function for node and pattern predicates:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30497.90168.patch
Type: text/x-patch
Size: 694 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170301/6f58d75b/attachment.bin>


More information about the llvm-commits mailing list