[PATCH] D30409: [SLP] Fix for PR32038: extra add of PHI node when it is not required.

Michael Kuperstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 28 16:36:39 PST 2017


mkuper added a comment.

Nice, I think it's a cleaner way to treat the phis than what we had originally, regardless of the bug.
LGTM.



================
Comment at: test/Transforms/SLPVectorizer/X86/scheduling.ll:15
 ; CHECK-NEXT:    [[TMP15:%.*]] = extractelement <4 x i32> [[BIN_RDX2]], i32 0
-; CHECK-NEXT:    [[ADD52:%.*]] = add nsw i32 [[TMP15]],
+; CHECK:         [[ADD52:%.*]] = add i32 [[TMP15]],
 ; CHECK:          ret i32 [[ADD52]]
----------------
You have a separate patch to get this flag back, right?


https://reviews.llvm.org/D30409





More information about the llvm-commits mailing list