[PATCH] D30380: Teach lit to expand glob expressions

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 28 13:43:22 PST 2017


mehdi_amini added a comment.

In https://reviews.llvm.org/D30380#688941, @MatzeB wrote:

> In https://reviews.llvm.org/D30380#688937, @zturner wrote:
>
> > In https://reviews.llvm.org/D30380#688936, @zturner wrote:
> >
> > > I don't think it's necessarily fair to classify these tests as poorly designed.  dynamic tools, by design, often need to do things with the file system and the tests need to verify this behavior.
> >
>


That's a reason to look at the filesystem, that's not a reason that explain why a test does not know in advance which file will be generated or need to be looked at. Can you clarify this?


https://reviews.llvm.org/D30380





More information about the llvm-commits mailing list