[PATCH] D29489: Optimize SETCC + VSEL of incompatible or illegal types

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

> X86/avx512-mask-op.ll

You're making this substantially worse because i1 vectors are legal in avx-512, so you're forcing unnatural transforms.

The other changes look fine, at a glance.

For your new SystemZ tests, CHECK-NOT can be useful to make sure you aren't generating something unexpected, but please make sure each test at least CHECKs that the compares/blends you expect are being correctly generated.

I'll look at the new code later.


https://reviews.llvm.org/D29489