[PATCH] D30422: Keep attributes, calling convention, etc, when remangling intrinsic

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy added inline comments.


================
Comment at: lib/IR/AutoUpgrade.cpp:1920
     assert(
         (CI->getCalledFunction()->getName() != NewFn->getName()) &&
         "Unknown function for CallInst upgrade and isn't just a name change");
----------------
dberlin wrote:
> sanjoy wrote:
> > Don't you need a `break;` here?
> No, this should return, sigh.
If you change this to a return then how about keeping `NewCall` uninitialized (instead of setting it to `CI`) above and removing the `NewCall != CI` check below?


https://reviews.llvm.org/D30422