[lld] r296429 - Add Triple::thumb to getBitcodeMachineKind

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 28 09:59:48 PST 2017


Testcase?

Sean Silva via llvm-commits <llvm-commits at lists.llvm.org> writes:

> Author: silvas
> Date: Mon Feb 27 21:00:48 2017
> New Revision: 296429
>
> URL: http://llvm.org/viewvc/llvm-project?rev=296429&view=rev
> Log:
> Add Triple::thumb to getBitcodeMachineKind
>
> We really need to find a way to get this info from a single point of
> truth in the LLVM backend, but it seems that the EM_* constants are
> buried deep inside the constructors of the MCAsmBackend's.
>
> For now, just fill in entries as we run into cases. AFAIK these mappings
> are largely immutable, so we get a 75% discount on the technical debt
> (code is duplicated, but little chance of divergence).
>
> Modified:
>     lld/trunk/ELF/InputFiles.cpp
>
> Modified: lld/trunk/ELF/InputFiles.cpp
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=296429&r1=296428&r2=296429&view=diff
> ==============================================================================
> --- lld/trunk/ELF/InputFiles.cpp (original)
> +++ lld/trunk/ELF/InputFiles.cpp Mon Feb 27 21:00:48 2017
> @@ -744,6 +744,7 @@ static uint8_t getBitcodeMachineKind(Mem
>    case Triple::aarch64:
>      return EM_AARCH64;
>    case Triple::arm:
> +  case Triple::thumb:
>      return EM_ARM;
>    case Triple::mips:
>    case Triple::mipsel:
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list