[PATCH] D30442: [AMDGPU] Add second pass of the scheduler

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 28 08:29:01 PST 2017


rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/GCNSchedStrategy.cpp:48-50
+  if (MF != &DAG->MF)
+    TargetOccupancy = 0;
+  MF = &DAG->MF;
----------------
tstellar wrote:
> tstellar wrote:
> > Can you store TargetOccupancy in the SIMachineFunctionInfo object?  I think that would be a little cleaner.
> To clarify:
> 
> TargetOccupancy = MFI->getTargetOccupancy();
It is the override for scheduler and it will not be always initialized to non-zero. I'm afraid if I expose this field in MFI it would be misleading.


Repository:
  rL LLVM

https://reviews.llvm.org/D30442





More information about the llvm-commits mailing list