[PATCH] D30400: For Thumb1, lower ADDC/ADDE/SUBC/SUBE via the glueless ARMISD nodes, same as already done for ARM and Thumb2.

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 28 06:45:28 PST 2017


rengolin added a comment.

Ok, just adding LLVM_FALLTHROUGH should be fine for me. I'll let Eli have a final look and approve.



================
Comment at: lib/Target/ARM/ARMISelDAGToDAG.cpp:3240
+  case ARMISD::SUBE:
+    if (Subtarget->hasV6Ops()) {
+
----------------
tyomitch wrote:
> rengolin wrote:
> > Why can't you leave this as an early break?
> Exactly because I want it to fall through to the next case, if the condition doesn't hold.
right, I thought as much.


https://reviews.llvm.org/D30400





More information about the llvm-commits mailing list