[PATCH] D30400: For Thumb1, lower ADDC/ADDE/SUBC/SUBE via the glueless ARMISD nodes, same as already done for ARM and Thumb2.

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

Few nits, but otherwise, looks good.



================
Comment at: lib/Target/ARM/ARMISelDAGToDAG.cpp:3240
+  case ARMISD::SUBE:
+    if (Subtarget->hasV6Ops()) {
+
----------------
Why can't you leave this as an early break?


================
Comment at: lib/Target/ARM/ARMISelDAGToDAG.cpp:3272
+    }
+    // fall through
+
----------------
use LLVM_FALLTHROUGH


https://reviews.llvm.org/D30400