[PATCH] D26872: Outliner: Add MIR-level outlining pass

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/Target/X86/X86InstrInfo.cpp:10439
+  // Don't allow debug values to impact outlining type.
+  if (MI.isDebugValue() || MI.isIndirectDebugValue())
+    return MachineOutlinerInstrType::Invisible;
----------------
Thanks!


================
Comment at: test/CodeGen/X86/machine-outliner-debuginfo.ll:43
+; CHECK-NEXT: movl  $4, -{{[0-9]+}}(%rbp)
+; CHECK-NEXT: retq
+
----------------
There should also be a negative check to ensure no DBG_VALUE is in the outlined function and that that no debug locations are attached to the outlined function.


https://reviews.llvm.org/D26872