[PATCH] D30419: [ELF] - Define __bss_start symbol.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Generally looking fine, but Rafael might be working on removing DefinedSynthetic class, so he probably want to take a look.



================
Comment at: test/ELF/bss-start.s:16
+
+.global __bss_start
+.text
----------------
Do you need this .global?


================
Comment at: test/ELF/bss-start.s:20-22
+
+ movl $1, a
+ movl $1, b
----------------
You can remove this without changing the meaning of this test, no?


https://reviews.llvm.org/D30419