[PATCH] D30377: [DebugInfo] [DWARFv5] Support for DW_AT_calling_convention for types

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: include/llvm/IR/DIBuilder.h:770-772
+    /// Replace ArgABI on a composite type.
+    void replaceArgABI(DICompositeType *&T, dwarf::CallingConvention ArgABI);
+
----------------
why does this attribute require a 'replace' API - generally all the values (including things like size/alignment) are provided up-front when the type is built, and do not require replacing/updating after that, if I recall/understand correctly.


https://reviews.llvm.org/D30377