[PATCH] D30414: [ARM] Don't pass -arm-execute-only to cc1as

[Christof Douma via Phabricator via llvm-commits]

christof created this revision.
Herald added a subscriber: aemerson.

The option -mexecute-only is translated into the backend option -arm-execute-only. But this option only makes sense for the compiler and the assembler does not recognize it. This patch stops clang from passing the option to the assembler.


Repository:
  rL LLVM

https://reviews.llvm.org/D30414

Files:
  lib/Driver/Arch/ARM.cpp
  test/Driver/arm-execute-only.c


Index: test/Driver/arm-execute-only.c
===================================================================
--- test/Driver/arm-execute-only.c
+++ test/Driver/arm-execute-only.c
@@ -90,10 +90,14 @@
 // RUN: not %clang -target armv8m.main-eabi -mpure-code -mlong-calls %s 2>&1 \
 // RUN:    | FileCheck %s -check-prefix CHECK-EXECUTE-ONLY-LONG-CALLS
 
+// RUN: %clang -target armv7m-eabi -x assembler -mexecute-only %s -c -### 2>&1 \
+// RUN:    | FileCheck %s -check-prefix CHECK-NO-EXECUTE-ONLY -check-prefix CHECK-NO-EXECUTE-ONLY-ASM
+
 //
 // CHECK-NO-EXECUTE-ONLY-NOT: "-backend-option" "-arm-execute-only"
 // CHECK-EXECUTE-ONLY: "-backend-option" "-arm-execute-only"
 
 // CHECK-EXECUTE-ONLY-NOT-SUPPORTED: error: execute only is not supported for the thumbv6m sub-architecture
 // CHECK-EXECUTE-ONLY-NO-MOVT: error: option '-mexecute-only' cannot be specified with '-mno-movt'
 // CHECK-EXECUTE-ONLY-LONG-CALLS: error: option '-mexecute-only' cannot be specified with '-mlong-calls'
+// CHECK-NO-EXECUTE-ONLY-ASM: warning: argument unused during compilation: '-mexecute-only'
Index: lib/Driver/Arch/ARM.cpp
===================================================================
--- lib/Driver/Arch/ARM.cpp
+++ lib/Driver/Arch/ARM.cpp
@@ -370,26 +370,29 @@
   }
 
   // Generate execute-only output (no data access to code sections).
-  // Supported only on ARMv6T2 and ARMv7 and above.
-  // Cannot be combined with -mno-movt or -mlong-calls
-  if (Arg *A = Args.getLastArg(options::OPT_mexecute_only, options::OPT_mno_execute_only)) {
-    if (A->getOption().matches(options::OPT_mexecute_only)) {
-      if (getARMSubArchVersionNumber(Triple) < 7 &&
-          llvm::ARM::parseArch(Triple.getArchName()) != llvm::ARM::AK_ARMV6T2)
-            D.Diag(diag::err_target_unsupported_execute_only) << Triple.getArchName();
-      else if (Arg *B = Args.getLastArg(options::OPT_mno_movt))
-        D.Diag(diag::err_opt_not_valid_with_opt) << A->getAsString(Args) << B->getAsString(Args);
-      // Long calls create constant pool entries and have not yet been fixed up
-      // to play nicely with execute-only. Hence, they cannot be used in
-      // execute-only code for now
-      else if (Arg *B = Args.getLastArg(options::OPT_mlong_calls, options::OPT_mno_long_calls)) {
-        if (B->getOption().matches(options::OPT_mlong_calls))
-          D.Diag(diag::err_opt_not_valid_with_opt) << A->getAsString(Args) << B->getAsString(Args);
+  // This only makes sense for the compiler, not for the assembler.
+  if (!ForAS) {
+      // Supported only on ARMv6T2 and ARMv7 and above.
+      // Cannot be combined with -mno-movt or -mlong-calls
+      if (Arg *A = Args.getLastArg(options::OPT_mexecute_only, options::OPT_mno_execute_only)) {
+        if (A->getOption().matches(options::OPT_mexecute_only)) {
+          if (getARMSubArchVersionNumber(Triple) < 7 &&
+              llvm::ARM::parseArch(Triple.getArchName()) != llvm::ARM::AK_ARMV6T2)
+                D.Diag(diag::err_target_unsupported_execute_only) << Triple.getArchName();
+          else if (Arg *B = Args.getLastArg(options::OPT_mno_movt))
+            D.Diag(diag::err_opt_not_valid_with_opt) << A->getAsString(Args) << B->getAsString(Args);
+          // Long calls create constant pool entries and have not yet been fixed up
+          // to play nicely with execute-only. Hence, they cannot be used in
+          // execute-only code for now
+          else if (Arg *B = Args.getLastArg(options::OPT_mlong_calls, options::OPT_mno_long_calls)) {
+            if (B->getOption().matches(options::OPT_mlong_calls))
+              D.Diag(diag::err_opt_not_valid_with_opt) << A->getAsString(Args) << B->getAsString(Args);
+          }
+
+          CmdArgs.push_back("-backend-option");
+          CmdArgs.push_back("-arm-execute-only");
+        }
       }
-
-      CmdArgs.push_back("-backend-option");
-      CmdArgs.push_back("-arm-execute-only");
-    }
   }
 
   // Kernel code has more strict alignment requirements.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30414.89896.patch
Type: text/x-patch
Size: 3992 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170227/5821fc48/attachment.bin>