[PATCH] D30355: [ARM] don't transform an add(ext Cond), C to select unless there's a setcc of the condition

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 27 09:13:03 PST 2017


spatel added a comment.

In https://reviews.llvm.org/D30355#687423, @spatel wrote:

> Patch updated based on Eli's feedback (thanks!):
>
> 1. Don't check CC.getNode() because that's obviously unnecessary.
> 2. Change "test_tst_assessment" to preserve the intent of that test (now there's only a diff for a thumb target).


Actually, there's no diff on that test from the proposed code change in this patch, so I should commit that before this patch as an independent change?


https://reviews.llvm.org/D30355





More information about the llvm-commits mailing list