[PATCH] D29840: test-release.sh: Remove workaround for test-suite build

[Renato Golin via Phabricator via llvm-commits]

rengolin added inline comments.


================
Comment at: utils/release/test-release.sh:409
 
     cd $BuildDir
+    if [ $do_test_suite = 'yes' ]; then
----------------
I'd move this line to the end, and move the "cd $BuildDir" just after the if, to make it clear that we want to be in that dir as we leave the function. The behaviour is the same, but adding new stuff to the end may confuse people and be wrong.


================
Comment at: utils/release/test-release.sh:411
+    if [ $do_test_suite = 'yes' ]; then
+      SandboxDir=`pwd`/'sandbox'
+      Lit=$SandboxDir/bin/lit
----------------
This could be "$BuildDir/sandbox" and with double quotes, to make sure directories with spaces won't break.


https://reviews.llvm.org/D29840