[PATCH] D30401: Refactor the multiply-accumulate combines to act on ARMISD::ADD[CE] nodes, instead of the generic ISD::ADD[CE].

[Sam Parker via Phabricator via llvm-commits]

samparker added a comment.

Hi Artyom,

Thanks for working on this, it really cleans up the code. Just a couple of inline comments from me.

cheers,
sam



================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:9451
   //                    ADDC   <- hiAdd
   //
+  assert(AddeNode->getOpcode() == ARMISD::ADDE && "Expect an ADDE");
----------------
I think it would be a good idea to update this comment with the new pattern.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:9563
   // While trying to combine for the other MLAL nodes, first search for the
   // chance to use UMAAL. Check if Addc uses another addc node which can first
   // be combined into a UMLAL. The other pattern is AddcNode being combined
----------------
just another small comment update required.


https://reviews.llvm.org/D30401