[PATCH] D29925: Implement intrinsic mangling for literal struct types.Fixes PR 31921

[mattias.v.eriksson@ericsson.com via Phabricator via llvm-commits]

materi added a comment.

In https://reviews.llvm.org/D29925#687131, @dberlin wrote:

> Sorry about that.
>  I wasn't aware intrinsics were allowed to have a calling convention, since they are internal to llvm.
>  No intrinsic defined  in Intrinsics* has one, from what i can tell, and as you can see, the code we use to upgrade generically does not do anything with calling convention either.
>  I'm not even sure what it would mean for an intrinsic to have a calling convention (instead of something it *lowers to* to have a calling convention).


Maybe we are just doing something stupid when we add a calling convention to our intrinsics.

I don't know exactly why we have this, maybe they are just an accident. Thanks for pointing it out!

> Assuming our position is that intrinsics themselves, can have a calling convention, there are two ways to fix this.

I'll experiment with removing all calling conventions from our intrinsics (in the out-of-tree target). It's possible our position should be that CC is not allowed.


Repository:
  rL LLVM

https://reviews.llvm.org/D29925