[PATCH] D30331: [ImplicitNullCheck] Add alias analysis usage

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 26 20:21:02 PST 2017


sanjoy added inline comments.


================
Comment at: lib/CodeGen/ImplicitNullChecks.cpp:358
+                MMO1->getAAInfo()),
+            MemoryLocation(MMO2->getValue(), MemoryLocation::UnknownSize,
+                MMO2->getAAInfo()));
----------------
skatkov wrote:
> sanjoy wrote:
> > What about multiple memoperands on the same machine instruction?
> Not sure it is possible but we can iterate over mem operands.
I'd also be happy with either of:

 - An assert that says that there is only one mem operand
 - A bailout if there are more than one mem operand (if they are very rare)



https://reviews.llvm.org/D30331





More information about the llvm-commits mailing list