[PATCH] D30351: De-template SharedSymbol.

[Rafael Avila de Espindola via llvm-commits]

Rafael Avila de Espindola <rafael.espindola at gmail.com> writes:

>>    if (WasInserted || isa<Undefined>(S->body())) {
>> -    replaceBody<SharedSymbol<ELFT>>(S, F, Name, Sym, Verdef);
>> +    replaceBody<SharedSymbol>(S, File, Name, Sym.st_other, Sym.getType(),
>> +                              Sym.st_shndx, Sym.st_value, Sym.st_size,
>> +                              getAlignment(File, Sym), Verdef);
>
> With this we know always compute the alignment, instead of doing so only
> when the symbol needs a copy relocation. Why?

I see that that is fixed in the new patch.

LGTM.

Cheers,
Rafael