[PATCH] D30381: [SCCP] Remove manual folding of terminator instructions.

[Xin Tong via Phabricator via llvm-commits]

trentxintong added a comment.

I understand there was a previous attempt at removing these code before and it caused a build break.

8ea5797013603a088dd6be6ad49d1a117f1955e2
[SCCP] Remove manual folding of terminator instructions.

4b6e5ecd86de0863546ab2ecf3a8f979f0d1a8a0
Revert "[SCCP] Remove manual folding of terminator instructions."
This reverts commit r288725 as it broke a bot.

I think the problem might be with the ConstantFoldTerminator in the assert(), should not
assert() be null'ed in release build ?

With this patch, I ran LTO on CPU2006 C/C++ benchmarks locally, they compiled and ran fine.

I also checked when the manual folding code is added, it is added in
ddaaa374879f2f736f7bfa20f4b25202fcb85708 at which time we only mark an edge executable
when its branching on an undef, but not setting its value to a constant.


https://reviews.llvm.org/D30381