[PATCH] D30148: AMDGPU/SI: Fix listing of Low and High latency instructions

Axel Davy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 25 13:38:46 PST 2017


axeldavy added a comment.

In https://reviews.llvm.org/D30148#682960, @arsenm wrote:

> It's still missing a few. VINTRP and EXP. I think it would be better to check instruction latency data. In absence of that, I think it would be simpler to just use isHighLatencyInstruction, and !isHighLatencyInstruction


The true usage of these helper functions is to deduce instructions which need a VMCNT wait or a LGKMCNT wait (former ones being incorrectly called 'high latency' and the latter ones 'lon latency').

What about renaming to isVMCNTInstruction and isLGKMCNTInstruction ?


Repository:
  rL LLVM

https://reviews.llvm.org/D30148





More information about the llvm-commits mailing list