[PATCH] D30371: [libfuzzer] use find to feed xargs

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 25 11:49:14 PST 2017


mehdi_amini added a comment.

In https://reviews.llvm.org/D30371#686712, @zturner wrote:

> Given that this problem keeps happening and is not likely to go away any time soon, I wonder if the best solution is to build some special syntax into lit that can expand globs.  lit already has plenty of cases where it does text replacements, for example if you write `%t` in a run line, or `{{.*}}` in a match line.


Nit: `{{.*}}` is a FileCheck expansion, not a lit one (unless I misunderstood what you mean).

> Could we add some sort of replacement sequence that can be used in run lines which expands a glob expression?  One idea for a possible syntax might be `%[expression]`, where `expression` can itself be another substituion sequence.  This would allow you to write line 3 above as:
> 
>   RUN: sancov -covered-functions %[LLVMFuzzer-NullDerefTest*] %[%t_workdir/*.sancov] | FileCheck %s --check-prefix=SANCOV

I'm not sure I understand the first expansion, but I'm fine with the second one!


https://reviews.llvm.org/D30371





More information about the llvm-commits mailing list