[lld] r296258 - Revert r296215, "[PDB] General improvements to Stream library." and followings.

[NAKAMURA Takumi via llvm-commits]

Author: chapuni
Date: Sat Feb 25 11:04:23 2017
New Revision: 296258

URL: http://llvm.org/viewvc/llvm-project?rev=296258&view=rev
Log:
Revert r296215, "[PDB] General improvements to Stream library." and followings.

r296215, "[PDB] General improvements to Stream library."
r296217, "Disable BinaryStreamTest.StreamReaderObject temporarily."
r296220, "Re-enable BinaryStreamTest.StreamReaderObject."
r296244, "[PDB] Disable some tests that are breaking bots."
r296249, "Add static_cast to silence -Wc++11-narrowing."

std::errc::no_buffer_space should be used for OS-oriented errors for socket transmission.
(Seek discussions around llvm/xray.)

I could substitute s/no_buffer_space/others/g, but I revert whole them ATM.

Could we define and use LLVM errors there?

Modified:
    lld/trunk/COFF/PDB.cpp

Modified: lld/trunk/COFF/PDB.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/PDB.cpp?rev=296258&r1=296257&r2=296258&view=diff
==============================================================================
--- lld/trunk/COFF/PDB.cpp (original)
+++ lld/trunk/COFF/PDB.cpp Sat Feb 25 11:04:23 2017
@@ -93,9 +93,9 @@ static std::vector<uint8_t> mergeDebugT(
     if (Data.empty())
       continue;
 
-    BinaryByteStream Stream(Data, llvm::support::little);
+    msf::ByteStream Stream(Data);
     codeview::CVTypeArray Types;
-    BinaryStreamReader Reader(Stream);
+    msf::StreamReader Reader(Stream);
     // Follow type servers.  If the same type server is encountered more than
     // once for this instance of `PDBTypeServerHandler` (for example if many
     // object files reference the same TypeServer), the types from the
@@ -137,9 +137,9 @@ static void dumpDebugS(ScopedPrinter &W,
   if (Data.empty())
     return;
 
-  BinaryByteStream Stream(Data, llvm::support::little);
+  msf::ByteStream Stream(Data);
   CVSymbolArray Symbols;
-  BinaryStreamReader Reader(Stream);
+  msf::StreamReader Reader(Stream);
   if (auto EC = Reader.readArray(Symbols, Reader.getLength()))
     fatal(EC, "StreamReader.readArray<CVSymbolArray> failed");
 
@@ -161,9 +161,9 @@ static void dumpCodeView(SymbolTable *Sy
 
 static void addTypeInfo(pdb::TpiStreamBuilder &TpiBuilder,
                         ArrayRef<uint8_t> Data) {
-  BinaryByteStream Stream(Data, llvm::support::little);
+  msf::ByteStream Stream(Data);
   codeview::CVTypeArray Records;
-  BinaryStreamReader Reader(Stream);
+  msf::StreamReader Reader(Stream);
   if (auto EC = Reader.readArray(Records, Reader.getLength()))
     fatal(EC, "Reader.readArray failed");
   for (const codeview::CVType &Rec : Records)