[PATCH] D30369: Allow None as a MemoryLocation to getModRefInfo, use it to start cleaning up interfaces and uses

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 24 18:37:09 PST 2017


dberlin added inline comments.


================
Comment at: include/llvm/Analysis/AliasAnalysis.h:550
     default:
       return MRI_NoModRef;
     }
----------------
This got clang-formatted when i reformatted the function.



================
Comment at: lib/Transforms/Utils/MemorySSA.cpp:110
       : MemoryLocOrCall(MUD->getMemoryInst()) {}
+  ~MemoryLocOrCall() {}
+  MemoryLocOrCall(const MemoryLocOrCall &MLOC) {
----------------
Sadly, we have to implement all of this because Optional has a non-trivial destructor/etc


https://reviews.llvm.org/D30369





More information about the llvm-commits mailing list