[PATCH] D29092: PR31729: [GVNHoist] Don't hoist unsafe scalars at -Oz

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 24 14:20:13 PST 2017


hans accepted this revision.
hans added a comment.

While the `if (OptForMinSize && isSafeToSpeculativelyExecute(I))` fix doesn't look great, and the discussion suggests there might be more fundamental problems with GVNHoist, at least this seems like a good stop-gap fix for 4.0.

If I understand correctly, the impact will be some compile-time reduction at `-Oz`, less hoisting, and more correctness.


https://reviews.llvm.org/D29092





More information about the llvm-commits mailing list