[PATCH] D30349: [AMDGPU] Runtime metadata fixes:

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPURuntimeMD.cpp:379-383
+  IIM.WavefrontSize = llvm::AMDGPU::IsaInfo::getWavefrontSize(Features);
+  IIM.LocalMemorySize = llvm::AMDGPU::IsaInfo::getLocalMemorySize(Features);
+  IIM.EUsPerCU = llvm::AMDGPU::IsaInfo::getEUsPerCU(Features);
+  IIM.MaxWavesPerEU = llvm::AMDGPU::IsaInfo::getMaxWavesPerEU(Features);
+  IIM.MaxFlatWorkGroupSize =
----------------
You don't need the llvm::'s


================
Comment at: test/MC/AMDGPU/runtime-metadata-invalid-1.s:106-125
+; Kernel info:
+; codeLenInByte = 40
+; NumSgprs: 6
+; NumVgprs: 3
+; FloatMode: 192
+; IeeeMode: 1
+; ScratchSize: 0
----------------
You can drop the extra comments here


https://reviews.llvm.org/D30349